linux-kernel - Re: [net-next PATCH v2 06/15] net: dsa: qca8k: move port set status/eee/ethtool stats function to common code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220719131820.7qs3w635sa6skaca@skbuf>
Date:   Tue, 19 Jul 2022 16:18:20 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Christian Marangi <ansuelsmth@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [net-next PATCH v2 06/15] net: dsa: qca8k: move port set
 status/eee/ethtool stats function to common code

On Tue, Jul 19, 2022 at 03:16:24PM +0200, Christian Marangi wrote:
> On Tue, Jul 19, 2022 at 04:14:51PM +0300, Vladimir Oltean wrote:
> > On Tue, Jul 19, 2022 at 02:57:17AM +0200, Christian Marangi wrote:
> > > The same logic to disable/enable port, set eee and get ethtool stats is
> > > used by drivers based on qca8k family switch.
> > > Move it to common code to make it accessible also by other drivers.
> > > 
> > > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > > ---
> > 
> > Reviewed-by: Vladimir Oltean <olteanv@...il.com>
> 
> (considering the ethtool function will change, is it OK to keep the
> review tag on the next revision?)

As long as the removed code is identical to the added one, yes.
If there are problems with the changes on the ethtool_stats function,
I'll leave my comments there.