linux-kernel - Re: [PATCH V16 14/14] irqchip / ACPI: Introduce ACPI_IRQ_MODEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa6eebe0-6bf3-ad40-f052-4ae360e99a34@loongson.cn>
Date:   Tue, 19 Jul 2022 21:41:36 +0800
From:   Jianmin Lv <lvjianmin@...ngson.cn>
To:     Huacai Chen <chenhuacai@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, loongarch@...ts.linux.dev,
        Hanjun Guo <guohanjun@...wei.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH V16 14/14] irqchip / ACPI: Introduce ACPI_IRQ_MODEL_LPIC
 for LoongArch



On 2022/7/19 上午10:25, Huacai Chen wrote:
> Hi, Jianmin,
> 
> On Mon, Jul 18, 2022 at 10:21 PM Jianmin Lv <lvjianmin@...ngson.cn> wrote:
>>
>> For LoongArch, ACPI_IRQ_MODEL_LPIC is introduced, and then the
>> callback acpi_get_gsi_domain_id and acpi_gsi_to_irq_fallback are
>> implemented.
>>
>> The acpi_get_gsi_domain_id callback returns related fwnode handle
>> of irqdomain for different GSI range.
>>
>> The acpi_gsi_to_irq_fallback will create new mapping for gsi when
>> the mapping of it is not found.
>>
>> Signed-off-by: Jianmin Lv <lvjianmin@...ngson.cn>
>> ---
>>   drivers/acpi/bus.c                  |  3 +++
>>   drivers/irqchip/irq-loongarch-cpu.c | 38 +++++++++++++++++++++++++++++++++++++
>>   include/linux/acpi.h                |  1 +
>>   3 files changed, 42 insertions(+)
>>
>> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
>> index 86fa61a..63fbf00 100644
>> --- a/drivers/acpi/bus.c
>> +++ b/drivers/acpi/bus.c
>> @@ -1145,6 +1145,9 @@ static int __init acpi_bus_init_irq(void)
>>          case ACPI_IRQ_MODEL_PLATFORM:
>>                  message = "platform specific model";
>>                  break;
>> +       case ACPI_IRQ_MODEL_LPIC:
>> +               message = "LPIC";
>> +               break;
>>          default:
>>                  pr_info("Unknown interrupt routing model\n");
>>                  return -ENODEV;
>> diff --git a/drivers/irqchip/irq-loongarch-cpu.c b/drivers/irqchip/irq-loongarch-cpu.c
>> index b4db430..a5e0bf0 100644
>> --- a/drivers/irqchip/irq-loongarch-cpu.c
>> +++ b/drivers/irqchip/irq-loongarch-cpu.c
>> @@ -16,6 +16,42 @@
>>   static struct irq_domain *irq_domain;
>>   struct fwnode_handle *cpuintc_handle;
>>
>> +static u32 lpic_gsi_to_irq(u32 gsi)
>> +{
>> +       /* Only pch irqdomain transferring is required for LoongArch. */
>> +       if (gsi >= GSI_MIN_PCH_IRQ && gsi <= GSI_MAX_PCH_IRQ)
>> +               return acpi_register_gsi(NULL, gsi, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_HIGH);
>> +
>> +       return 0;
>> +}
>> +
>> +static struct fwnode_handle *lpic_get_gsi_domain_id(u32 gsi)
>> +{
>> +       int id;
>> +       struct fwnode_handle *domain_handle = NULL;
>> +
>> +       switch (gsi) {
>> +       case GSI_MIN_CPU_IRQ ... GSI_MAX_CPU_IRQ:
>> +               if (liointc_handle)
>> +                       domain_handle = liointc_handle;
>> +               break;
>> +
>> +       case GSI_MIN_LPC_IRQ ... GSI_MAX_LPC_IRQ:
>> +               if (pch_lpc_handle)
>> +                       domain_handle = pch_lpc_handle;
>> +               break;
>> +
>> +       case GSI_MIN_PCH_IRQ ... GSI_MAX_PCH_IRQ:
>> +               id = find_pch_pic(gsi);
>> +               if (id >= 0 && pch_pic_handle[id])
>> +                       domain_handle = pch_pic_handle[id];
>> +
> Remove this blank line, please.
> 

Ok, thanks.


> Huacai
>> +               break;
>> +       }
>> +
>> +       return domain_handle;
>> +}
>> +
>>   static void mask_loongarch_irq(struct irq_data *d)
>>   {
>>          clear_csr_ecfg(ECFGF(d->hwirq));
>> @@ -102,6 +138,8 @@ static int __init cpuintc_acpi_init_v1(union acpi_subtable_headers *header,
>>                  panic("Failed to add irqdomain for LoongArch CPU");
>>
>>          set_handle_irq(&handle_cpu_irq);
>> +       acpi_set_irq_model(ACPI_IRQ_MODEL_LPIC, lpic_get_gsi_domain_id);
>> +       acpi_set_gsi_to_irq_fallback(lpic_gsi_to_irq);
>>          acpi_cascade_irqdomain_init();
>>
>>          return 0;
>> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
>> index e2b60d5..76520f3 100644
>> --- a/include/linux/acpi.h
>> +++ b/include/linux/acpi.h
>> @@ -105,6 +105,7 @@ enum acpi_irq_model_id {
>>          ACPI_IRQ_MODEL_IOSAPIC,
>>          ACPI_IRQ_MODEL_PLATFORM,
>>          ACPI_IRQ_MODEL_GIC,
>> +       ACPI_IRQ_MODEL_LPIC,
>>          ACPI_IRQ_MODEL_COUNT
>>   };
>>
>> --
>> 1.8.3.1
>>
>>