linux-kernel - Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7aeaf711-c18f-3442-be44-d820f2539a15@openvpn.net>
Date:   Tue, 19 Jul 2022 17:21:23 +0200
From:   Antonio Quartulli <antonio@...nvpn.net>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco)

On 19/07/2022 17:19, Andrew Lunn wrote:
> As a general comment throughout the code, pr_ functions are not
> liked. Since this is a network device, it would be better to use
> netdev_debug(), netdev_warn() etc, so indicating which device is
> outputting warnings or debug info.

Thanks for the hint, Andrew!
I will convert the pr_* calls to netdev_*.

Regards,

-- 
Antonio Quartulli
OpenVPN Inc.