linux-kernel - Re: [PATCH 1/2] RDMA/erdma: Use the bitmap API to allocate bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7075158a-64c1-8f69-7de1-9a60ee914f05@wanadoo.fr>
Date:   Tue, 19 Jul 2022 17:36:36 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Cheng Xu <chengyou@...ux.alibaba.com>,
        Jason Gunthorpe <jgg@...pe.ca>
Cc:     Kai Shen <kaishen@...ux.alibaba.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Leon Romanovsky <leon@...nel.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH 1/2] RDMA/erdma: Use the bitmap API to allocate bitmaps

Le 19/07/2022 à 15:01, Dan Carpenter a écrit :
> On Tue, Jul 19, 2022 at 09:54:34AM -0300, Jason Gunthorpe wrote:
>> On Tue, Jul 12, 2022 at 12:01:10PM +0300, Dan Carpenter wrote:
>>
>>> Best not to use any auto-formatting tools.  They are all bad.
>>
>> Have you tried clang-format? I wouldn't call it bad..
> 
> I prefered Christophe's formatting to clang's.  ;)
> 
> regards,
> dan carpenter
> 
> 

Hi,

checkpatch.pl only gives hints and should not blindly be taken as THE 
reference, but:

   ./scripts/checkpatch.pl -f --strict 
drivers/infiniband/hw/erdma/erdma_cmdq.c

gives:
   CHECK: Lines should not end with a '('
   #81: FILE: drivers/infiniband/hw/erdma/erdma_cmdq.c:81:
   +	cmdq->comp_wait_bitmap = devm_bitmap_zalloc(

   total: 0 errors, 0 warnings, 1 checks, 493 lines checked

(some other files in the same directory also have some checkpatch 
warning/error)



Don't know if it may be an issue for maintainers.

CJ