[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a78473a8-d4f9-d525-104d-2d08f92a1873@gmail.com>
Date: Tue, 19 Jul 2022 09:11:29 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: linux-kernel@...r.kernel.org
Cc: Markus Mayer <mmayer@...adcom.com>,
Sumeet Pawnikar <sumeet.r.pawnikar@...el.com>,
Alejandro González
<alejandro.gonzalez.correo@...il.com>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Amit Kucheria <amitk@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
Markus Mayer <markus.mayer@...adcom.com>,
"open list:THERMAL" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH RESEND] tools/thermal: tmon: include pthread and time
headers in tmon.h
On 7/17/2022 8:10 PM, Florian Fainelli wrote:
> From: Markus Mayer <mmayer@...adcom.com>
>
> Include sys/time.h and pthread.h in tmon.h, so that types
> "pthread_mutex_t" and "struct timeval tv" are known when tmon.h
> references them.
>
> Without these headers, compiling tmon against musl-libc will fail with
> these errors:
>
> In file included from sysfs.c:31:0:
> tmon.h:47:8: error: unknown type name 'pthread_mutex_t'
> extern pthread_mutex_t input_lock;
> ^~~~~~~~~~~~~~~
> make[3]: *** [<builtin>: sysfs.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> In file included from tui.c:31:0:
> tmon.h:54:17: error: field 'tv' has incomplete type
> struct timeval tv;
> ^~
> make[3]: *** [<builtin>: tui.o] Error 1
> make[2]: *** [Makefile:83: tmon] Error 2
>
> Signed-off-by: Markus Mayer <mmayer@...adcom.com>
> Acked-by: Florian Fainelli <f.fainelli@...il.com>
> Reviewed-by: Sumeet Pawnikar <sumeet.r.pawnikar@...el.com>
> Acked-by: Alejandro González <alejandro.gonzalez.correo@...il.com>
> Tested-by: Alejandro González <alejandro.gonzalez.correo@...il.com>
> ---
> This patch was first submitted here:
>
> https://lore.kernel.org/all/20200617235809.6817-1-mmayer@broadcom.com/
>
> but never applied, meanwhile the issue is still present
Daniel, Rafael, any chance to get that into v5.19-rc7? I should probably
also have added:
Fixes: 94f69966faf8 ("tools/thermal: Introduce tmon, a tool for thermal
subsystem")
Thanks!
--
Florian
Powered by blists - more mailing lists