linux-kernel - Re: [PATCH] Documentation: ACPI: EINJ: Fix obsolete example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtbmOlaDdKCVBUFI@agluck-desk3.sc.intel.com>
Date:   Tue, 19 Jul 2022 10:13:30 -0700
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Qifu Zhang <zhangqifu@...edance.com>
Cc:     rafael@...nel.org, lenb@...nel.org, jarkko@...nel.org,
        dave.hansen@...ux.intel.com, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation: ACPI: EINJ: Fix obsolete example

On Tue, Jul 19, 2022 at 07:50:13PM +0800, Qifu Zhang wrote:
> Since commit 488dac0c9237 ("libfs: fix error cast of negative value in
> simple_attr_write()"), the EINJ debugfs interface no longer accepts
> negative values as input. Attempt to do so will result in EINVAL.
> 
> Signed-off-by: Qifu Zhang <zhangqifu@...edance.com>

Reviewed-by: Tony Luck <tony.luck@...el.com>

> ---
>  Documentation/firmware-guide/acpi/apei/einj.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/firmware-guide/acpi/apei/einj.rst b/Documentation/firmware-guide/acpi/apei/einj.rst
> index 55e2331a6438..d6b61d22f525 100644
> --- a/Documentation/firmware-guide/acpi/apei/einj.rst
> +++ b/Documentation/firmware-guide/acpi/apei/einj.rst
> @@ -168,7 +168,7 @@ An error injection example::
>    0x00000008	Memory Correctable
>    0x00000010	Memory Uncorrectable non-fatal
>    # echo 0x12345000 > param1		# Set memory address for injection
> -  # echo $((-1 << 12)) > param2		# Mask 0xfffffffffffff000 - anywhere in this page
> +  # echo 0xfffffffffffff000 > param2		# Mask - anywhere in this page
>    # echo 0x8 > error_type			# Choose correctable memory error
>    # echo 1 > error_inject			# Inject now
>  
> -- 
> 2.20.1
>