linux-kernel - Re: [PATCH v5 10/12] thermal/of: Store the trips in the thermal zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jul 2022 20:24:19 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Daniel Lezcano <daniel.lezcano@...exp.org>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "Zhang, Rui" <rui.zhang@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kevin Hilman <khilman@...libre.com>,
        Alexandre Bailon <abailon@...libre.com>,
        Lukasz Luba <lukasz.luba@....com>,
        Amit Kucheria <amitk@...nel.org>
Subject: Re: [PATCH v5 10/12] thermal/of: Store the trips in the thermal zone

On Sun, Jul 10, 2022 at 2:35 PM Daniel Lezcano
<daniel.lezcano@...exp.org> wrote:
>
> As the thermal zone contains the trip point, we can store them
> directly when registering the thermal zone. That will allow another
> step forward to remove the duplicate thermal zone structure we find in
> the thermal_of code.
>
> Cc: Alexandre Bailon <abailon@...libre.com>
> Cc: Kevin Hilman <khilman@...libre.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...exp.org>
> ---
>  drivers/thermal/thermal_of.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
> index 19243c57b3f4..e187461dd396 100644
> --- a/drivers/thermal/thermal_of.c
> +++ b/drivers/thermal/thermal_of.c
> @@ -1119,11 +1119,9 @@ int __init of_parse_thermal_zones(void)
>                 tzp->slope = tz->slope;
>                 tzp->offset = tz->offset;
>
> -               zone = thermal_zone_device_register(child->name, tz->ntrips,
> -                                                   mask, tz,
> -                                                   ops, tzp,
> -                                                   tz->passive_delay,
> -                                                   tz->polling_delay);
> +               zone = thermal_zone_device_register_with_trips(child->name, tz->trips, tz->ntrips,
> +                                                              mask, tz, ops, tzp, tz->passive_delay,
> +                                                              tz->polling_delay);
>                 if (IS_ERR(zone)) {
>                         pr_err("Failed to build %pOFn zone %ld\n", child,
>                                PTR_ERR(zone));
> --

IMO it would be less confusing if this was merged with the patch
introducing thermal_zone_device_register_with_trips().