linux-kernel - Re: [PATCH 1/5] net: usb: ax88179_178a: remove redundant init code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220719134155.409fe0e6@kernel.org>
Date:   Tue, 19 Jul 2022 13:41:55 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     justinpopo6@...il.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, jannh@...gle.com, jackychou@...x.com.tw,
        jesionowskigreg@...il.com, joalonsof@...il.com, pabeni@...hat.com,
        edumazet@...gle.com, davem@...emloft.net, f.fainelli@...il.com,
        justin.chen@...adcom.com
Subject: Re: [PATCH 1/5] net: usb: ax88179_178a: remove redundant init code

On Mon, 18 Jul 2022 16:58:05 -0700 justinpopo6@...il.com wrote:
> From: Justin Chen <justinpopo6@...il.com>
> 
> Bind and reset are basically doing the same thing. Remove the duplicate
> code and have bind call into reset.
> 
> Signed-off-by: Justin Chen <justinpopo6@...il.com>

drivers/net/usb/ax88179_178a.c:1329:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable]
        u8 *tmp;
            ^
drivers/net/usb/ax88179_178a.c:1328:7: warning: variable 'tmp16' set but not used [-Wunused-but-set-variable]
        u16 *tmp16;
             ^