[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK8P3a0qcd6pZ=9fGapGexBMifp68jVezQou0QuK9As9vCyfyg@mail.gmail.com>
Date: Tue, 19 Jul 2022 23:16:40 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@...il.com>,
Richard Zhu <hongxing.zhu@....com>,
Lucas Stach <l.stach@...gutronix.de>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Rob Herring <robh@...nel.org>,
WilczyĆski <kw@...ux.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
linux-pci <linux-pci@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux-Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: build failure of next-20220718 due to 'imx6_pcie_host_exit'
defined but not used
On Tue, Jul 19, 2022 at 11:04 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> commit 0e4daeaa52ca ("PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS()")
> Author: Bjorn Helgaas <bhelgaas@...gle.com>
> Date: Tue Jul 19 15:50:18 2022 -0500
>
> PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS()
>
> Replace SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() with NOIRQ_SYSTEM_SLEEP_PM_OPS(),
> which has the advantage that the compiler always sees the PM callbacks as
> referenced, so they don't need to be wrapped with "#ifdef CONFIG_PM_SLEEP"
> or tagged with "__maybe_unused" to avoid "defined but not used" warnings.
>
> See 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones").
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
Reviewed-by: Arnd Bergmann <arnd@...db.de>
Powered by blists - more mailing lists