linux-kernel - Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <574ad23b-45c9-1bc3-0a86-c7cb73ea07bf@acm.org>
Date:   Tue, 19 Jul 2022 16:07:05 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Can Guo <quic_cang@...cinc.com>, stanley.chu@...iatek.com,
        adrian.hunter@...el.com, alim.akhtar@...sung.com,
        avri.altman@....com, beanhuo@...ron.com, quic_asutoshd@...cinc.com,
        quic_nguyenb@...cinc.com, quic_ziqichen@...cinc.com,
        linux-scsi@...r.kernel.org, kernel-team@...roid.com
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Daejun Park <daejun7.park@...sung.com>,
        Jinyoung Choi <j-young.choi@...sung.com>,
        Kiwoong Kim <kwmad.kim@...sung.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

On 7/19/22 00:01, Can Guo wrote:
> Adds MCQ support to UFS driver.

The description of this patch is too short. It should be explained how 
the UFSHCI queues are made visible to the block layer. It should also be 
explained which roles are assigned to queues and how (HCTX_TYPE_*). How 
the MAXQ configuration register is handled should also be explained.

The host lock is obtained in multiple UFSHCI 3.0 code paths. Information 
about the role of the host lock in MCQ code should be provided.

Thanks,

Bart.