linux-kernel - Re: [PATCH] net: ethernet: mtk_eth_soc: fix off by one check of ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165820201413.29134.11488522402561841559.git-patchwork-notify@kernel.org>
Date:   Tue, 19 Jul 2022 03:40:14 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Tom Rix <trix@...hat.com>
Cc:     nbd@....name, john@...ozen.org, sean.wang@...iatek.com,
        Mark-MC.Lee@...iatek.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, matthias.bgg@...il.com,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: fix off by one check of
 ARRAY_SIZE

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Sat, 16 Jul 2022 17:46:54 -0400 you wrote:
> In mtk_wed_tx_ring_setup(.., int idx, ..), idx is used as an index here
>   struct mtk_wed_ring *ring = &dev->tx_ring[idx];
> 
> The bounds of idx are checked here
>   BUG_ON(idx > ARRAY_SIZE(dev->tx_ring));
> 
> If idx is the size of the array, it will pass this check and overflow.
> So change the check to >= .
> 
> [...]

Here is the summary with links:
  - net: ethernet: mtk_eth_soc: fix off by one check of ARRAY_SIZE
    https://git.kernel.org/netdev/net/c/3696c952da07

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html