linux-kernel - Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f77038b5-93f5-1a06-c433-2086df8c3f3d@gmail.com>
Date:   Mon, 18 Jul 2022 21:06:59 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Wolfram Sang <wsa@...nel.org>, linux-kernel@...r.kernel.org,
        Kamal Dasu <kdasu.kdev@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        "open list:BROADCOM BRCMSTB I2C DRIVER" <linux-i2c@...r.kernel.org>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional
 interrupts



On 7/18/2022 8:57 PM, Wolfram Sang wrote:
> 
>> I was not sure if we could change the adapter name reported as one could
>> argue this is now ABI, but if we can, then using dev_name() is probably
>> better. You are the maintainer you so know the rules on what is considered
>> stable ABI and what is not :)
> 
> Well, then even removing ":" would break the ABI :)
> 
> Please use dev_name. Other drivers changed that string, too. We never
> gave guarantees for that one.
> 

Fair enough, sent a v2 using dev_name(), thanks!
-- 
Florian