linux-kernel - Re: [PATCH] crypto: hisilicon/zip: Use the bitmap API to allocate bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00da8a58-e4d0-40c9-0b4a-011ca0754c77@wanadoo.fr>
Date:   Tue, 19 Jul 2022 08:00:40 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Yang Shen <shenyang39@...wei.com>,
        Zhou Wang <wangzhou1@...ilicon.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH] crypto: hisilicon/zip: Use the bitmap API to allocate
 bitmaps

Le 15/07/2022 à 10:33, Herbert Xu a écrit :
> On Sat, Jul 09, 2022 at 06:16:46PM +0200, Christophe JAILLET wrote:
>> Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
>>
>> It is less verbose and it improves the semantic.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>> ---
>>   drivers/crypto/hisilicon/zip/zip_crypto.c | 9 ++++-----
>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/crypto/hisilicon/zip/zip_crypto.c b/drivers/crypto/hisilicon/zip/zip_crypto.c
>> index 67869513e48c..7bf53877e508 100644
>> --- a/drivers/crypto/hisilicon/zip/zip_crypto.c
>> +++ b/drivers/crypto/hisilicon/zip/zip_crypto.c
>> @@ -606,8 +606,7 @@ static int hisi_zip_create_req_q(struct hisi_zip_ctx *ctx)
>>   		req_q = &ctx->qp_ctx[i].req_q;
>>   		req_q->size = QM_Q_DEPTH;
>>   
>> -		req_q->req_bitmap = kcalloc(BITS_TO_LONGS(req_q->size),
>> -					    sizeof(long), GFP_KERNEL);
>> +		req_q->req_bitmap = bitmap_zalloc(req_q->size, GFP_KERNEL);
>>   		if (!req_q->req_bitmap) {
>>   			ret = -ENOMEM;
>>   			if (i == 0)
> 
> You should add an include for linux/bitmap.h instead of relying
> on implicit inclusion through some random header file.

Hi, most of the patches are accepted as-is, so I will not resend all of 
them.
I'll only add the #include if a v2 is needed or for new patches.

Thanks for the review and comment.

CJ

> 
> The same goes for all your other patches too.
> 
> Thanks,