[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YtZKylMu4jEa/oDp@ravnborg.org>
Date: Tue, 19 Jul 2022 08:10:18 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Caleb Connolly <caleb@...nolly.tech>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Thierry Reding <thierry.reding@...il.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Sumit Semwal <sumit.semwal@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH 3/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel
Hi Caleb,
On Mon, Jul 18, 2022 at 10:30:50PM +0100, Caleb Connolly wrote:
> From: Sumit Semwal <sumit.semwal@...aro.org>
>
> LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel.
A few things to improve to this binding.
Sam
>
> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> Signed-off-by: Sumit Semwal <sumit.semwal@...aro.org>
> [caleb: convert to yaml]
> Signed-off-by: Caleb Connolly <caleb@...nolly.tech>
> ---
> .../bindings/display/panel/lg,43408.yaml | 41 +++++++++++++++++++
> .../display/panel/panel-simple-dsi.yaml | 2 +
> 2 files changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/lg,43408.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/lg,43408.yaml b/Documentation/devicetree/bindings/display/panel/lg,43408.yaml
> new file mode 100644
> index 000000000000..0529a3aa2692
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/lg,43408.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LG SW43408 1080x2160 DSI panel
> +
> +maintainers:
> + - Caleb Connolly <caleb@...nolly.tech>
> +
> +description: |
> + This panel is used on the Pixel 3, it is a 60hz OLED panel which
> + required DSC (Display Stream Compression) and has rounded corners.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - const: lg,sw43408
> +
> + vddi-supply: true
> + vpnl-supply: true
> + reset-gpios: true
> +
> + backlight: false
> + power-supply: false
No need to say anything is false, this is covered by the statement below.
Also, the driver uses backlight, so it should be true?
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - data-mapping
> + - width-mm
> + - height-mm
> + - panel-timing
> + - port
> +
> +...
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index 2c00813f5d20..4498078cb1ee 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -45,6 +45,8 @@ properties:
> - lg,acx467akm-7
> # LG Corporation 7" WXGA TFT LCD panel
> - lg,ld070wx3-sl01
> + # LG Corporation sw43408 1080x2160 OLED
> + - lg,sw43408
The panel uses three power-supplies, so it is not a "panel-simple"
binding. And we cannot have the same compatible twice, so this must be
dropped.
Sam
Powered by blists - more mailing lists