linux-kernel - Re: [PATCH 3/3] clk: meson: s4: add s4 SoC clock controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50078eed-3c24-a4b5-1e21-3187daa9867a@amlogic.com>
Date:   Tue, 19 Jul 2022 14:58:27 +0800
From:   Yu Tu <yu.tu@...ogic.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <linux-clk@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: Re: [PATCH 3/3] clk: meson: s4: add s4 SoC clock controller driver

Hi Krzysztof,
	Thank you very much for your prompt reply.

On 2022/7/19 14:29, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 19/07/2022 08:02, Yu Tu wrote:
>> Hi Krzysztof,
>> 	Thank you for your advice.
>>
>> On 2022/7/12 17:44, Krzysztof Kozlowski wrote:
>>> [ EXTERNAL EMAIL ]
>>>
>>> On 08/07/2022 08:27, Yu Tu wrote:
>>>> Add the peripheral clock controller found in the s4 SoC family.
>>>>
>>>> Signed-off-by: Yu Tu <yu.tu@...ogic.com>
>>>> ---
>>>>    MAINTAINERS                |    2 +-
>>>>    drivers/clk/meson/Kconfig  |   17 +
>>>>    drivers/clk/meson/Makefile |    1 +
>>>>    drivers/clk/meson/s4.c     | 4678 ++++++++++++++++++++++++++++++++++++
>>>>    drivers/clk/meson/s4.h     |  156 ++
>>>>    5 files changed, 4853 insertions(+), 1 deletion(-)
>>>>    create mode 100644 drivers/clk/meson/s4.c
>>>>    create mode 100644 drivers/clk/meson/s4.h
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index e4ca46c5c8a1..f116ec0642f2 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -1772,7 +1772,7 @@ M:	Jerome Brunet <jbrunet@...libre.com>
>>>>    L:	linux-amlogic@...ts.infradead.org
>>>>    S:	Maintained
>>>>    F:	Documentation/devicetree/bindings/clock/amlogic*
>>>> -F:	drivers/clk/meson/
>>>> +F:	drivers/clk/meson/*
>>>
>>> Why?
>> Warning is displayed when using checkpatch. I will correct it.
> 
> What warning?
  ./scripts/checkpatch.pl --strict 
0001-clk-meson-s4-add-s4-SoC-clock-controller-driver.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
If I add that strange change, I won't have this WARNING.
Should I ignore this warning?
> 
> Best regards,
> Krzysztof
> 
> .