linux-kernel - Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03065912-a9f0-6380-6f19-9db2f43be589@gmail.com>
Date:   Mon, 18 Jul 2022 17:15:25 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Wolfram Sang <wsa@...nel.org>, linux-kernel@...r.kernel.org,
        Kamal Dasu <kdasu.kdev@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        "open list:BROADCOM BRCMSTB I2C DRIVER" <linux-i2c@...r.kernel.org>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional
 interrupts



On 7/16/2022 5:40 AM, Wolfram Sang wrote:
> On Wed, Jul 06, 2022 at 10:21:15AM -0700, Florian Fainelli wrote:
>> When the adapter is registered without interrupts, we would be showing
>> the following:
>>
>>    # i2cdetect -l
>>    i2c-3   i2c             Broadcom STB :                          I2C adapter
> 
> What about switching to pdev->name here? That way you also get the base
> address for free to differentiate if there are multiple instances on the
> SoC?

I was not sure if we could change the adapter name reported as one could 
argue this is now ABI, but if we can, then using dev_name() is probably 
better. You are the maintainer you so know the rules on what is 
considered stable ABI and what is not :)
-- 
Florian