linux-kernel - Re: [PATCH V4 net-next] net: marvell: prestera: add phylink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00e2c14ffd5bb2214b4d5553c1ed1d331b4cc355.camel@redhat.com>
Date:   Tue, 19 Jul 2022 11:07:17 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Yevhen Orlov <yevhen.orlov@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "andrew@...n.ch" <andrew@...n.ch>
Subject: Re: [PATCH V4 net-next] net: marvell: prestera: add phylink support

On Tue, 2022-07-19 at 08:56 +0000, Oleksandr Mazur wrote:
> > > +
> > > +static void prestera_pcs_an_restart(struct phylink_pcs *pcs)
> > > +{
> > > +     /*
> > > +      * TODO: add 100basex AN restart support
> 
> > Possibly typo above ? s/100basex/1000basex/
> 
> Hello Paolo, yes, you're right.
> So, should i wait some time before resubmitting patch again with
> changes - V5 - or it's okay to resubmit new version now?

My personal take: v4 has been out for several days, so it's ok to
submit a new revision now. Others may disagre, but you would be free to
point the finger against me for the suggestion :)

Please additionally have a look to my other comment, regarding
read_lock usage.

Thanks!

Paolo