linux-kernel - Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27ab24ec-61c7-cafb-6665-a16c58808649@linaro.org>
Date:   Tue, 19 Jul 2022 11:53:46 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, l.stach@...gutronix.de
Cc:     kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        laurent.pinchart@...asonboard.com, marex@...x.de,
        paul.elder@...asonboard.com, aford173@...il.com,
        Markus.Niebel@...tq-group.com, alexander.stein@...tq-group.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, aisheng.dong@....com,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl

On 19/07/2022 07:50, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse
> the i.MX8MM VPU blk ctrl yaml file. And add description for the items.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml      | 90 +++++++++++++++++--
>  include/dt-bindings/power/imx8mp-power.h      |  4 +
>  2 files changed, 85 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
> index b3fb529b399c..14f92574286f 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
> @@ -30,20 +30,13 @@ properties:
>      maxItems: 4
>  
>    power-domain-names:
> -    items:
> -      - const: bus
> -      - const: g1
> -      - const: g2
> -      - const: h1
> +    maxItems: 4
>  
>    clocks:
>      maxItems: 3
>  
>    clock-names:
> -    items:
> -      - const: g1
> -      - const: g2
> -      - const: h1
> +    maxItems: 3
>  
>  required:
>    - compatible
> @@ -53,6 +46,85 @@ required:
>    - clocks
>    - clock-names
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx8mm-vpu-blk-ctrl
> +    then:
> +      properties:
> +        power-domains:
> +          items:
> +            - description: bus power domain
> +            - description: G1 decoder power domain
> +            - description: G2 decoder power domain
> +            - description: H1 encoder power domain
> +
> +        power-domain-names:
> +          items:
> +            - const: bus
> +            - const: g1
> +            - const: g2
> +            - const: h1
> +
> +        clocks:
> +          items:
> +            - description: G1 decoder clk
> +            - description: G2 decoder clk
> +            - description: H1 encoder clk
> +
> +        clock-names:
> +          items:
> +            - const: g1
> +            - const: g2
> +            - const: h1
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx8mp-vpu-blk-ctrl
> +    then:
> +      properties:
> +        power-domains:
> +          items:
> +            - description: bus power domain
> +            - description: G1 decoder power domain
> +            - description: G2 decoder power domain
> +            - description: VC8000E encoder power domain
> +
> +        power-domain-names:
> +          items:
> +            - const: bus
> +            - const: g1
> +            - const: g2
> +            - const: vc8000e
> +
> +        clocks:
> +          items:
> +            - description: G1 decoder clk
> +            - description: G2 decoder clk
> +            - description: VC8000E encoder clk
> +
> +        clock-names:
> +          items:
> +            - const: g1
> +            - const: g2
> +            - const: vc8000e
> +
> +        interconnects:
> +          items:
> +            - description: G1 decoder interconnect
> +            - description: G2 decoder interconnect
> +            - description: VC8000E encoder interconnect
> +
> +        interconnect-names:
> +          items:
> +            - const: g1
> +            - const: g2
> +            - const: vc8000e

Include interconnects+names in list of all properties and disallow them
for other variants.


Best regards,
Krzysztof