linux-kernel - Re: [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <895e7df5-65e5-7b26-81d6-864e68957ab6@linaro.org>
Date:   Tue, 19 Jul 2022 12:18:45 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Francesco Dolcini <francesco@...cini.it>
Cc:     Martyn Welch <martyn.welch@...labora.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM
 and carrier board

On 19/07/2022 12:15, Francesco Dolcini wrote:
> Hello Krzysztof,
> 
> On Tue, Jul 19, 2022 at 12:01:34PM +0200, Krzysztof Kozlowski wrote:
>> On 18/07/2022 17:23, Martyn Welch wrote:
>>> +	tca6424: gpio@22 {
>>> +		compatible = "ti,tca6424";
>>> +		pinctrl-names = "default";
>>> +		pinctrl-0 = <&pinctrl_tca6424>;
>>> +		reg = <0x22>;
>>
>> compatible, then reg, then all other properties. This applies everywhere.
> 
> Is this documented somewhere? It would be easier to enable new people to
> contribute, if it was.

Unfortunately it's not documented. It's a common practice - most
popular, but of course you will find other examples. There is reasoning
behind - compatible is the most important property. Reg is useful to
have at the top as it must match unit address.

> Anyway, I would add to this list status as last, when present, 

Yes, this as well in some trees is recommended/enforced although not
documented.

> and I do
> try to order alphabetically all the other properties.
Best regards,
Krzysztof