linux-kernel - [PATCH] clk/ti/adpll: remove useless comparison in ti_adpll_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220719102319.5912-1-strochuk@ispras.ru>
Date:   Tue, 19 Jul 2022 13:23:19 +0300
From:   Andrey Strachuk <strochuk@...ras.ru>
To:     Tero Kristo <kristo@...nel.org>
Cc:     Andrey Strachuk <strochuk@...ras.ru>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Colin Ian King <colin.i.king@...glemail.com>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: [PATCH] clk/ti/adpll: remove useless comparison in ti_adpll_free_resources()

Local variable 'ac' is initialized by an address
of field of ti_adpll_data, so it does not make
sense to compare 'ac' with NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Strachuk <strochuk@...ras.ru>
Fixes: 21330497f303 ("clk: ti: Add support for dm814x ADPLL")
---
 drivers/clk/ti/adpll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
index 962502ca7ff0..7207915f9440 100644
--- a/drivers/clk/ti/adpll.c
+++ b/drivers/clk/ti/adpll.c
@@ -772,7 +772,7 @@ static void ti_adpll_free_resources(struct ti_adpll_data *d)
 	for (i = TI_ADPLL_M3; i >= 0; i--) {
 		struct ti_adpll_clock *ac = &d->clocks[i];
 
-		if (!ac || IS_ERR_OR_NULL(ac->clk))
+		if (IS_ERR_OR_NULL(ac->clk))
 			continue;
 		if (ac->cl)
 			clkdev_drop(ac->cl);
-- 
2.25.1