linux-kernel - Re: [RFC Patch net-next 02/10] net: dsa: microchip: add common gigabit set and get function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220719103740.pk4cqzcfwu2byc5h@skbuf>
Date:   Tue, 19 Jul 2022 13:37:40 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Arun Ramadoss <arun.ramadoss@...rochip.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King <linux@...linux.org.uk>
Subject: Re: [RFC Patch net-next 02/10] net: dsa: microchip: add common
 gigabit set and get function

On Tue, Jul 12, 2022 at 09:33:00PM +0530, Arun Ramadoss wrote:
> This patch add helper function for setting and getting the gigabit
> enable for the ksz series switch. KSZ8795 switch has different register
> address compared to all other ksz switches. KSZ8795 series uses the Port
> 5 Interface control 6 Bit 6 for configuring the 1Gbps or 100/10Mbps
> speed selection. All other switches uses the xMII control 1 0xN301
> register Bit6 for gigabit.
> Further, for KSZ8795 & KSZ9893 switches if bit 1 then 1Gbps is chosen
> and if bit 0 then 100/10Mbps is chosen. It is other way around for
> other switches bit 0 is for 1Gbps. So, this patch implements the common
> function for configuring the gigabit set and get capability.
> 
> Signed-off-by: Arun Ramadoss <arun.ramadoss@...rochip.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>