linux-kernel - Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=XaDTJp+JLrwW7Hh5-7g0y_Vhqqtiv01quBh6wZZWQgmw@mail.gmail.com>
Date:   Wed, 20 Jul 2022 08:11:50 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Yunlong Jia <yunlong.jia@....corp-partner.google.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Henry Sun <henrysun@...gle.com>,
        Bob Moragues <moragues@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

Hi,

On Wed, Jul 20, 2022 at 12:37 AM Yunlong Jia
<yunlong.jia@....corp-partner.google.com> wrote:
>
> SKU6 is LTE(w/o eSIM)+WIFI+Parade
>
> Signed-off-by: Yunlong Jia <yunlong.jia@....corp-partner.google.com>
> ---
>
>  arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> index 764c451c1a857..767cb7450c0d8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> @@ -14,7 +14,7 @@
>
>  / {
>         model = "Google Pazquel (Parade,LTE)";
> -       compatible = "google,pazquel-sku4", "qcom,sc7180";
> +       compatible = "google,pazquel-sku6", "google,pazquel-sku4", "qcom,sc7180";

Now this doesn't match the bindings. The bindings list 4 first and
then 6. You are listing 6 first then 4. The order doesn't really
matter, but the two places need to match.

As Krzysztof says, you should be incrementing the version of your
patches, adding some history, and you should also put the two patches
in one series.

I believe you're using patman, so something like this and have _both_
changes applied and send them out.

In patch #1 (the bindings):

Series-changes: 3
- Bindings and dts in the same series.

In patch #2 (the dts):

Series-version: 3

Series-changes: 2
- Put sku6 before sku4

Series-changes: 3
- Bindings and dts in the same series.

-Doug