linux-kernel - Re: [PATCH 2/2] gpiolib: acpi: Add a quirk for Asus UM325UAZ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <12c1ef93-74d7-6e41-bb9b-f030ab20c97f@amd.com>
Date:   Wed, 20 Jul 2022 10:43:23 -0500
From:   "Limonciello, Mario" <mario.limonciello@....com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Pavel Krc <reg.krn@...c.net>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH 2/2] gpiolib: acpi: Add a quirk for Asus UM325UAZ

On 7/20/2022 08:57, Andy Shevchenko wrote:
> I am on vacation (Mika also iirc), but I believe that Hans can review 
> it, so resend with cc’ing him and add above as a comment to the change, 
> or better cover letter.

Thanks, I redirected the original messages to Hans.  Enjoy your vacation.

> 
> On Tuesday, July 19, 2022, Mario Limonciello <mario.limonciello@....com 
> <mailto:mario.limonciello@....com>> wrote:
> 
>     Asus UM325UAZ has GPIO 18 programmed as both an interrupt and a wake
>     source, but confirmed with internal team on this design this pin is
>     floating and shouldn't have been programmed. This causes lots of
>     spurious IRQs on the system and horrendous battery life.
> 
>     Add a quirk to ignore attempts to program this pin on this system.
> 
>     Reported-and-tested-by: Pavel Krc <reg.krn@...c.net
>     <mailto:reg.krn@...c.net>>
>     Link: https://bugzilla.kernel.org/show_bug.cgi?id=216208
>     <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D216208&data=05%7C01%7Cmario.limonciello%40amd.com%7C2c67d6b468d44e177dbb08da6a57d2fd%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637939222681842692%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=INWMYURdKmQeTaFw1PT%2BEohTJGJSRRONYJCTw9klXu4%3D&reserved=0>
>     Signed-off-by: Mario Limonciello <mario.limonciello@....com
>     <mailto:mario.limonciello@....com>>
>     ---
>       drivers/gpio/gpiolib-acpi.c | 14 ++++++++++++++
>       1 file changed, 14 insertions(+)
> 
>     diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
>     index 375942d92d6f..2149713ea8f1 100644
>     --- a/drivers/gpio/gpiolib-acpi.c
>     +++ b/drivers/gpio/gpiolib-acpi.c
>     @@ -1586,6 +1586,20 @@ static const struct dmi_system_id
>     gpiolib_acpi_quirks[] __initconst = {
>                              .ignore_wake = "INT33FF:01@0",
>                      },
>              },
>     +       {
>     +               /*
>     +                * Interrupt storm caused from edge triggered
>     floating pin
>     +                * Found in BIOS UX325UAZ.300
>     +                *
>     https://bugzilla.kernel.org/show_bug.cgi?id=216208
>     <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D216208&data=05%7C01%7Cmario.limonciello%40amd.com%7C2c67d6b468d44e177dbb08da6a57d2fd%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637939222681842692%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=INWMYURdKmQeTaFw1PT%2BEohTJGJSRRONYJCTw9klXu4%3D&reserved=0>
>     +                */
>     +               .matches = {
>     +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER
>     INC."),
>     +                       DMI_MATCH(DMI_PRODUCT_NAME, "ZenBook
>     UX325UAZ_UM325UAZ"),
>     +               },
>     +               .driver_data = &(struct acpi_gpiolib_dmi_quirk) {
>     +                       .ignore_interrupt = "AMDI0030:00@18",
>     +               },
>     +       },
>              {} /* Terminating entry */
>       };
> 
>     -- 
>     2.34.1
> 
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>