linux-kernel - RE: [PATCH] EDAC/ghes: Fix buffer overflow in ghes_edac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH7PR84MB18380BBEA0E8C1A4A3721865828E9@PH7PR84MB1838.NAMPRD84.PROD.OUTLOOK.COM>
Date:   Wed, 20 Jul 2022 16:17:50 +0000
From:   "Kani, Toshi" <toshi.kani@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     "rrichter@...vell.com" <rrichter@...vell.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "Elliott, Robert (Servers)" <elliott@....com>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] EDAC/ghes: Fix buffer overflow in ghes_edac_register()

Borislav Petkov wrote:
> I think it'll be more user-friendly to put
>
> "PROC 1 DIMM 1" for device
>
> and
>
> "NA" or so for bank
>
> instead of setting the label to the NULL string.
>
> I.e., relax that
> 
> 	if (bank && *bank && device && *device)
> 
> check there.

Good idea.  I will send a v2 patch to set "NA" in case device or bank
is null.

Thanks,
Toshi