linux-kernel - Re: [PATCH] dt-bindings: arm: qcom: Document additional sku6 for sc7180 pazquel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Jul 2022 18:46:30 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Yunlong Jia <yunlong.jia@....corp-partner.google.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Henry Sun <henrysun@...gle.com>,
        Bob Moragues <moragues@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: arm: qcom: Document additional sku6 for
 sc7180 pazquel

On 20/07/2022 17:07, Doug Anderson wrote:
> Hi,
> 
> On Wed, Jul 20, 2022 at 12:46 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 20/07/2022 09:38, Yunlong Jia wrote:
>>> The difference between sku6 and sku4 is that there is no esim
>>>
>>> Signed-off-by: Yunlong Jia <yunlong.jia@....corp-partner.google.com>
>>> ---
>>>
>>>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> index 4dd18fbf20b6..aebeefdab27f 100644
>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> @@ -410,6 +410,7 @@ properties:
>>>        - description: Google Pazquel with LTE and Parade (newest rev)
>>>          items:
>>>            - const: google,pazquel-sku4
>>> +          - const: google,pazquel-sku6
>>
>> This looks wrong, did you test it?
> 
> Why do you think it's wrong? This patch is adding a second compatible
> string to an existing dts. 

Because it was sent after a patch adding sku6+sku4+sc7180, but the order
here is different.

However for some reason it was not part of a patchset which makes it
total mess and even less possible to understand.

> The only difference between SKU4 and SKU6
> is that one of them has the eSIM component stuffed and the other one
> doesn't. This need not be represented in the dts since the eSIM is
> automatically detected, but it was still stuffed as a SKU strapping so
> the factory could tell whether the missing eSIM was an error or
> intentional.
> 
> This is just like the SKU0 vs. SKU2 difference.
> 
> Other than the fact that this should be together in one series with
> the dts patch:
> 
> Reviewed-by: Douglas Anderson <dianders@...omium.org>

I don't agree. With last DTS patch this is a wrong binding (or wrong
DTS) therefore I must NAK it.

Please do not upstream stuff in some different way, like sending
bindings and DTS separate.

Best regards,
Krzysztof