linux-kernel - Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd6e30b2-55da-eca8-d4fc-fdc143f340f7@quicinc.com>
Date:   Wed, 20 Jul 2022 10:34:43 -0700
From:   "Asutosh Das (asd)" <quic_asutoshd@...cinc.com>
To:     Bart Van Assche <bvanassche@....org>,
        Can Guo <quic_cang@...cinc.com>, <stanley.chu@...iatek.com>,
        <adrian.hunter@...el.com>, <alim.akhtar@...sung.com>,
        <avri.altman@....com>, <beanhuo@...ron.com>,
        <quic_nguyenb@...cinc.com>, <quic_ziqichen@...cinc.com>,
        <linux-scsi@...r.kernel.org>, <kernel-team@...roid.com>
CC:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Daejun Park <daejun7.park@...sung.com>,
        Jinyoung Choi <j-young.choi@...sung.com>,
        Kiwoong Kim <kwmad.kim@...sung.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

Hi Bart,

On 7/19/2022 4:07 PM, Bart Van Assche wrote:
> On 7/19/22 00:01, Can Guo wrote:
>> Adds MCQ support to UFS driver.
> 
> The description of this patch is too short. It should be explained how 
> the UFSHCI queues are made visible to the block layer. It should also be 
> explained which roles are assigned to queues and how (HCTX_TYPE_*). How 
> the MAXQ configuration register is handled should also be explained.
> 
> The host lock is obtained in multiple UFSHCI 3.0 code paths. Information 
> about the role of the host lock in MCQ code should be provided.
> 
> Thanks,
> 
> Bart.
Thanks for having taken a look.
I'll check the comments and upload a next version.

-asd