linux-kernel - Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UEt4fcVaFvS8nr7Z0GNYM1T=mz7iUhwg+bBkWtbO4c1g@mail.gmail.com>
Date:   Wed, 20 Jul 2022 10:53:54 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Yunlong Jia <yunlong.jia@....corp-partner.google.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Henry Sun <henrysun@...gle.com>,
        Bob Moragues <moragues@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

Hi,

On Wed, Jul 20, 2022 at 9:55 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 20/07/2022 17:13, Doug Anderson wrote:
> > Hi,
> >
> > On Tue, Jul 19, 2022 at 11:10 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@...aro.org> wrote:
> >>
> >> On 20/07/2022 04:51, Yunlong Jia wrote:
> >>> SKU6 is LTE(w/o eSIM)+WIFI+Parade
> >>>
> >>> Signed-off-by: Yunlong Jia <yunlong.jia@....corp-partner.google.com>
> >>> ---
> >>>
> >>>  arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> >>> index 764c451c1a857..4649eaec6318d 100644
> >>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> >>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> >>> @@ -14,7 +14,7 @@
> >>>
> >>>  / {
> >>>       model = "Google Pazquel (Parade,LTE)";
> >>> -     compatible = "google,pazquel-sku4", "qcom,sc7180";
> >>> +     compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
> >>
> >> You miss binding change and sku6 should be rather added before sku4 as
> >> it is more specific, isn't it?
> >
> > Just to close the loop: the order doesn't matter at all. Neither sku4
> > nor sku6 is "more specific". One has the eSIM stuffed and one doesn't.
>
> Thanks Doug. Then the commit description could be improved, so reviewer
> does not have to ask such questions. Otherwise it is confusing to see a
> board which says it is for LTE version but it is actually not for LTE
> version (or whatever combination you have).

Yeah. I guess it makes more sense with the background knowledge that
the different SKUs are:

LTE with physical SIM _and_ eSIM
LTE with only a physical SIM
WiFi only

...so both sku4 and sku6 are LTE SKUs. One has the eSIM stuffed and
one doesn't. There is a single shared device tree for the two.

-Doug