linux-kernel - Re: [PATCH] ASoC: ti: remove sound support for DaVinci DM644x and DM646x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de72dd7f-639b-1733-a38b-a0ed9346f3d9@gmail.com>
Date:   Wed, 20 Jul 2022 21:36:18 +0300
From:   Péter Ujfalusi <peter.ujfalusi@...il.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: ti: remove sound support for DaVinci DM644x and
 DM646x

Hi Lukas,

On 20/07/2022 14:21, Lukas Bulwahn wrote:
> Commit 7dd33764486d ("ARM: davinci: Delete DM644x board files") and commit
> b4aed01de486 ("ARM: davinci: Delete DM646x board files") removes the
> support for DaVinci DM644x and DM646x boards.
> 
> Hence, remove the sound support for those boards as well.

This is not going to remove the sound support, it is just removes the
select, which is now rendered NOP as neither MACH_DAVINCI_EVM nor
MACH_DAVINCI_DM6467_EVM is an option to select...

There is still structs and some code in davinci-evm.c in the path of
if (machine_is_davinci_evm())
and
else if (machine_is_davinci_dm6467_evm())

Those can also go, but I can only  drop that in about two weeks from now...

Acked-by: Peter Ujfalusi <peter.ujfalusi@...il.com>

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>  sound/soc/ti/Kconfig | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig
> index 40110e9a9e8a..35fddd7c501a 100644
> --- a/sound/soc/ti/Kconfig
> +++ b/sound/soc/ti/Kconfig
> @@ -180,9 +180,6 @@ config SND_SOC_DAVINCI_EVM
>  	select SND_SOC_DAVINCI_ASP if MACH_DAVINCI_DM355_EVM
>  	select SND_SOC_DAVINCI_ASP if SND_SOC_DM365_AIC3X_CODEC
>  	select SND_SOC_DAVINCI_VCIF if SND_SOC_DM365_VOICE_CODEC
> -	select SND_SOC_DAVINCI_ASP if MACH_DAVINCI_EVM # DM6446
> -	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DM6467_EVM
> -	select SND_SOC_SPDIF if MACH_DAVINCI_DM6467_EVM
>  	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DA830_EVM
>  	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DA850_EVM
>  	select SND_SOC_TLV320AIC3X
> @@ -191,8 +188,6 @@ config SND_SOC_DAVINCI_EVM
>  	  DaVinci EVM platforms:
>  	  - DM355
>  	  - DM365
> -	  - DM6446
> -	  - DM6447
>  	  - DM830
>  	  - DM850
>  

-- 
Péter