linux-kernel - Re: [PATCH] ASoC:do not initialise statics to 0.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71f92970-1e76-ed47-e878-d66f747aec86@intel.com>
Date:   Wed, 20 Jul 2022 22:09:27 +0200
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Xin Gao <gaoxin@...rlc.com>, <perex@...ex.cz>, <tiwai@...e.com>
CC:     <fred.oh@...ux.intel.com>, <akihiko.odaki@...il.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC:do not initialise statics to 0.

On 2022-07-20 9:58 PM, Xin Gao wrote:
> do not initialise statics to 0.

Hello,

Please do not repeat the title in the commit message - brings no value.
Also, the spelling isn't correct - s/initialise/initialize/.

I'd suggest to adhere to title formatting common to given subsystem. git 
log should help you understand which scopes should be part of commit 
title for changes targeting Intel code in ASoC domain. Last but not 
least, title is not a sentence - drop the full stop at the end of it.


Regards,
Czarek

> Signed-off-by: Xin Gao <gaoxin@...rlc.com>
> ---
>   sound/soc/intel/boards/cht_bsw_rt5645.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/boards/cht_bsw_rt5645.c b/sound/soc/intel/boards/cht_bsw_rt5645.c
> index 45c301ea5e00..8a8b25589c55 100644
> --- a/sound/soc/intel/boards/cht_bsw_rt5645.c
> +++ b/sound/soc/intel/boards/cht_bsw_rt5645.c
> @@ -50,7 +50,7 @@ struct cht_mc_private {
>   #define CHT_RT5645_SSP0_AIF2     BIT(18)
>   #define CHT_RT5645_PMC_PLT_CLK_0 BIT(19)
>   
> -static unsigned long cht_rt5645_quirk = 0;
> +static unsigned long cht_rt5645_quirk;
>   
>   static void log_quirks(struct device *dev)
>   {