linux-kernel - Re: [PATCH] apparmor: correct config reference to intended one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <847ef193-71a7-9714-be20-2cbb654e9c09@canonical.com>
Date:   Wed, 20 Jul 2022 13:24:34 -0700
From:   John Johansen <john.johansen@...onical.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Paul Moore <paul@...l-moore.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E . Hallyn" <serge@...lyn.com>, apparmor@...ts.ubuntu.com,
        linux-security-module@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apparmor: correct config reference to intended one

On 7/20/22 05:04, Lukas Bulwahn wrote:
> Commit 5bfcbd22ee4e ("apparmor: Enable tuning of policy paranoid load for
> embedded systems") introduces the config SECURITY_APPARMOR_PARANOID_LOAD,
> but then refers in the code to SECURITY_PARANOID_LOAD; note the missing
> APPARMOR in the middle.
> 
> Correct this to the introduced and intended config option.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

thanks, I have pulled this into apparmor-next

Acked-by: John Johansen <john.johansen@...onical.com>

> ---
>   security/apparmor/lsm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index 090a20805664..e29cade7b662 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -1402,7 +1402,7 @@ module_param_named(path_max, aa_g_path_max, aauint, S_IRUSR);
>    * DEPRECATED: read only as strict checking of load is always done now
>    * that none root users (user namespaces) can load policy.
>    */
> -bool aa_g_paranoid_load = IS_ENABLED(CONFIG_SECURITY_PARANOID_LOAD);
> +bool aa_g_paranoid_load = IS_ENABLED(CONFIG_SECURITY_APPARMOR_PARANOID_LOAD);
>   module_param_named(paranoid_load, aa_g_paranoid_load, aabool, S_IRUGO);
>   
>   static int param_get_aaintbool(char *buffer, const struct kernel_param *kp);