linux-kernel - Re: [PATCH] PCI: fu740: Remove unnecessary include files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Jul 2022 17:49:53 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Paul Walmsley <paul.walmsley@...ive.com>,
        Greentime Hu <greentime.hu@...ive.com>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] PCI: fu740: Remove unnecessary include files

On Tue, Jul 19, 2022 at 12:33:21PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> fu740 uses no syscon or regman interfaces, so it doesn't need to include
> mfs/syscon.h.  It uses no regulator interfaces, so it doesn't need to
> include regulator/consumer.h either.
> 
> Remove both unnecessary includes.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Applied to pci/ctrl/fu740 for v5.20.  Let me know if you object.

> ---
>  drivers/pci/controller/dwc/pcie-fu740.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c
> index 02cc70d8cc06..e8b008f73f34 100644
> --- a/drivers/pci/controller/dwc/pcie-fu740.c
> +++ b/drivers/pci/controller/dwc/pcie-fu740.c
> @@ -16,11 +16,9 @@
>  #include <linux/gpio.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/kernel.h>
> -#include <linux/mfd/syscon.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
>  #include <linux/platform_device.h>
> -#include <linux/regulator/consumer.h>
>  #include <linux/resource.h>
>  #include <linux/types.h>
>  #include <linux/interrupt.h>
> -- 
> 2.25.1
>