linux-kernel - [intel-tdx:guest-attest 5/8] arch/x86/coco/tdx/attest.c:246:6: warning: no previous prototype for function 'terminate_quote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 20 Jul 2022 08:32:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
        Andi Kleen <ak@...ux.intel.com>
Subject: [intel-tdx:guest-attest 5/8] arch/x86/coco/tdx/attest.c:246:6:
 warning: no previous prototype for function 'terminate_quote_request'

tree:   https://github.com/intel/tdx.git guest-attest
head:   7dd2b3e1f9d655ffb17fafb777d77d860b3a42ea
commit: 28cd09ae55b12e152d390c37224a15c43f7621e5 [5/8] x86/tdx: Add Quote generation support
config: x86_64-buildonly-randconfig-r002-20220718 (https://download.01.org/0day-ci/archive/20220720/202207200845.YVJavepg-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fa0c7639e91fa1cd0cf2ff0445a1634a90fe850a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel/tdx/commit/28cd09ae55b12e152d390c37224a15c43f7621e5
        git remote add intel-tdx https://github.com/intel/tdx.git
        git fetch --no-tags intel-tdx guest-attest
        git checkout 28cd09ae55b12e152d390c37224a15c43f7621e5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/coco/tdx/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/x86/coco/tdx/attest.c:246:6: warning: no previous prototype for function 'terminate_quote_request' [-Wmissing-prototypes]
   void terminate_quote_request(struct quote_entry *entry)
        ^
   arch/x86/coco/tdx/attest.c:246:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void terminate_quote_request(struct quote_entry *entry)
   ^
   static 
   1 warning generated.


vim +/terminate_quote_request +246 arch/x86/coco/tdx/attest.c

   244	
   245	/* Handles early termination of GetQuote requests */
 > 246	void terminate_quote_request(struct quote_entry *entry)
   247	{
   248		struct tdx_quote_hdr *quote_hdr;
   249	
   250		/*
   251		 * For early termination, if the request is not yet
   252		 * processed by VMM (GET_QUOTE_IN_FLIGHT), the VMM
   253		 * still owns the shared buffer, so mark the request
   254		 * invalid to let quote_callback_handler() handle the
   255		 * memory cleanup function. If the request is already
   256		 * processed, then do the cleanup and return.
   257		 */
   258	
   259		mutex_lock(&quote_lock);
   260		quote_hdr = (struct tdx_quote_hdr *)entry->buf.vmaddr;
   261		if (quote_hdr->status == GET_QUOTE_IN_FLIGHT) {
   262			entry->valid = false;
   263			mutex_unlock(&quote_lock);
   264			return;
   265		}
   266		_del_quote_entry(entry);
   267		mutex_unlock(&quote_lock);
   268	}
   269	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp