linux-kernel - Re: [net-next PATCH v4 4/5] net: ethernet: stmicro: stmmac: generate stmmac dma conf before open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jul 2022 18:07:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Christian Marangi <ansuelsmth@...il.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH v4 4/5] net: ethernet: stmicro: stmmac:
 generate stmmac dma conf before open

On Tue, 19 Jul 2022 03:32:18 +0200 Christian Marangi wrote:
> Rework the driver to generate the stmmac dma_conf before stmmac_open.
> This permits a function to first check if it's possible to allocate a
> new dma_config and then pass it directly to __stmmac_open and "open" the
> interface with the new configuration.

You missed one kdoc:

> @@ -1711,9 +1744,11 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags)
>   * and allocates the socket buffers. It supports the chained and ring
>   * modes.
>   */
> -static int __init_dma_tx_desc_rings(struct stmmac_priv *priv, u32 queue)
> +static int __init_dma_tx_desc_rings(struct stmmac_priv *priv,
> +				    struct stmmac_dma_conf *dma_conf,
> +				    u32 queue)
>  {

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1750: warning: Function parameter or member 'dma_conf' not described in '__init_dma_tx_desc_rings'