linux-kernel - Re: [PATCH net-next] tcp: fix condition for increasing pingpong count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Jul 2022 14:47:11 +0800
From:   LemmyHuang <hlm3280@....com>
To:     kuba@...nel.org
Cc:     davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
        hlm3280@....com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next] tcp: fix condition for increasing pingpong count

At 2022-07-20 08:49:15, "Jakub Kicinski" <kuba@...nel.org> wrote:
> On Tue, 19 Jul 2022 21:01:37 +0800 LemmyHuang wrote:
>> -	if (before(tp->lsndtime, icsk->icsk_ack.lrcvtime) &&
>> +	if ((tp->lsndtime <= icsk->icsk_ack.lrcvtime) &&
>
> Are you sure you don't need to take care of the values wrapping?
> before() does that. You may want !after() if you want to allow equal.

Yeap, I will switch to that in v2.
Thank you!