linux-kernel - Re: [PATCH] usb: trancevibrator: simplify tv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Jul 2022 10:08:42 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     dzm91@...t.edu.cn
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, mudongliangabcd@...il.com
Subject: Re: [PATCH] usb: trancevibrator: simplify tv_probe

Le 20/07/2022 à 09:56, Dongliang Mu a écrit :
> On Wed, Jul 20, 2022 at 3:46 PM Christophe JAILLET
> <christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@...lic.gmane.org> wrote:
>>
>> Le 20/07/2022 à 09:23, Dongliang Mu a écrit :
>>> From: Dongliang Mu <mudongliangabcd-Re5JQEeQqe8AvxtiuMwx3w-XMD5yJDbdMToUJ55TTLPZA@...lic.gmane.org.org>
>>>
>>> The function tv_probe does not need to invoke kfree when the
>>> allocation fails. So let's simplify the code of tv_probe.
>>> Another change is to remove a redundant space.
>>>
>>> Signed-off-by: Dongliang Mu <mudongliangabcd-Re5JQEeQqe8AvxtiuMwx3w@...lic.gmane.org>
>>> ---
>>>    drivers/usb/misc/trancevibrator.c | 13 +++----------
>>>    1 file changed, 3 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/trancevibrator.c
>>> index 26baba3ab7d7..30d4d774d448 100644
>>> --- a/drivers/usb/misc/trancevibrator.c
>>> +++ b/drivers/usb/misc/trancevibrator.c
>>> @@ -84,29 +84,22 @@ static int tv_probe(struct usb_interface *interface,
>>>    {
>>>        struct usb_device *udev = interface_to_usbdev(interface);
>>>        struct trancevibrator *dev;
>>> -     int retval;
>>>
>>>        dev = kzalloc(sizeof(struct trancevibrator), GFP_KERNEL);
>>> -     if (!dev) {
>>> -             retval = -ENOMEM;
>>> -             goto error;
>>> -     }
>>> +     if (!dev)
>>> +             return -ENOMEM;
>>>
>>>        dev->udev = usb_get_dev(udev);
>>>        usb_set_intfdata(interface, dev);
>>>
>>>        return 0;
>>
>> Hi,
>>
>> looks like:
>>
>> error:
>>          kfree(dev);
>>          return retval;
>>
>> at the end of the function can be removed as-well.
>>
> 
> My patch actually removes them.

Sorry for the noise.

My mailer or newsgroup server sometimes plays me some tricks and only 
displays partial message :(.

CJ

> 
>> Just my 2c.
>>
>> CJ
>