linux-kernel - Re: [PATCH 3/3] iommu: mtk_iommu: add support for MT8365 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220720085213.3803-1-aouledameur@baylibre.com>
Date:   Wed, 20 Jul 2022 10:52:13 +0200
From:   Amjad Ouled-Ameur <aouledameur@...libre.com>
To:     fparent@...libre.com
Cc:     iommu@...ts.linux-foundation.org, joro@...tes.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, matthias.bgg@...il.com,
        will@...nel.org, yong.wu@...iatek.com,
        Amjad Ouled-Ameur <aouledameur@...libre.com>
Subject: Re: [PATCH 3/3] iommu: mtk_iommu: add support for MT8365 SoC

Hi Fabien,

Thank you for the fix.

The kernel would panic if you boot with this patchset because
bank_nr and bank_enable are not set in mt8365_data.

Please add this change:

--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -1538,6 +1538,8 @@ static const struct mtk_iommu_plat_data mt8365_data = {
 	.m4u_plat     = M4U_MT8365,
 	.flags	      = RESET_AXI,
 	.inv_sel_reg  = REG_MMU_INV_SEL_GEN1,
+	.banks_num    = 1,
+	.banks_enable = {true},
 	.iova_region  = single_domain,
 	.iova_region_nr = ARRAY_SIZE(single_domain),
 	.larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}}, /* Linear mapping. */

With this change, please add my:
Reviewed-by: Amjad Ouled-Ameur <aouledameur@...libre.com>
Tested-by: Amjad Ouled-Ameur <aouledameur@...libre.com>

Regards,
Amjad