linux-kernel - [jsarha:topic/cros-sof-v4.14 1739/9354] include/asm-generic/bug.h:58:35: error: this statement may fall through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 20 Jul 2022 18:49:50 +0800
From:   kernel test robot <lkp@...el.com>
To:     Michel Thierry <michel.thierry@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Nathan Ciobanu <nathan.d.ciobanu@...el.com>
Subject: [jsarha:topic/cros-sof-v4.14 1739/9354]
 include/asm-generic/bug.h:58:35: error: this statement may fall through

Hi Michel,

FYI, the error/warning still remains.

tree:   https://github.com/jsarha/linux topic/cros-sof-v4.14
head:   6f750b16c322c9191168a3a97c427c90581d9144
commit: a0825191170f9ec92c030c4682b1d5b6b0c99071 [1739/9354] UPSTREAM: drm/i915: Add a default case in gen7 hwsp switch-case
config: i386-randconfig-a002-20220718 (https://download.01.org/0day-ci/archive/20220720/202207201854.HVbv5g7g-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
        # https://github.com/jsarha/linux/commit/a0825191170f9ec92c030c4682b1d5b6b0c99071
        git remote add jsarha https://github.com/jsarha/linux
        git fetch --no-tags jsarha topic/cros-sof-v4.14
        git checkout a0825191170f9ec92c030c4682b1d5b6b0c99071
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/bug.h:82:0,
                    from include/linux/bug.h:5,
                    from include/linux/debug_locks.h:7,
                    from include/linux/lockdep.h:28,
                    from include/linux/spinlock_types.h:18,
                    from include/linux/mutex.h:16,
                    from include/linux/kernfs.h:13,
                    from include/linux/sysfs.h:16,
                    from include/linux/kobject.h:21,
                    from include/linux/cdev.h:5,
                    from include/drm/drmP.h:36,
                    from drivers/gpu/drm/i915/intel_ringbuffer.c:31:
   drivers/gpu/drm/i915/intel_ringbuffer.c: In function 'intel_ring_setup_status_page':
>> include/asm-generic/bug.h:58:35: error: this statement may fall through [-Werror=implicit-fallthrough=]
    #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
                                      ^
   drivers/gpu/drm/i915/i915_gem.h:31:26: note: in expansion of macro 'BUG_ON'
    #define GEM_BUG_ON(expr) BUG_ON(expr)
                             ^~~~~~
   drivers/gpu/drm/i915/intel_ringbuffer.c:410:4: note: in expansion of macro 'GEM_BUG_ON'
       GEM_BUG_ON(engine->id);
       ^~~~~~~~~~
   drivers/gpu/drm/i915/intel_ringbuffer.c:411:3: note: here
      case RCS:
      ^~~~
   cc1: all warnings being treated as errors


vim +58 include/asm-generic/bug.h

^1da177e4c3f41 Linus Torvalds  2005-04-16  56  
^1da177e4c3f41 Linus Torvalds  2005-04-16  57  #ifndef HAVE_ARCH_BUG_ON
2a41de48b81e61 Alexey Dobriyan 2007-07-17 @58  #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
^1da177e4c3f41 Linus Torvalds  2005-04-16  59  #endif
^1da177e4c3f41 Linus Torvalds  2005-04-16  60  

:::::: The code at line 58 was first introduced by commit
:::::: 2a41de48b81e61fbe260ae5031ebcb6f935f35fb Fix sparse false positives re BUG_ON(ptr)

:::::: TO: Alexey Dobriyan <adobriyan@...ru>
:::::: CC: Linus Torvalds <torvalds@...dy.linux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp