[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YtfodwyLc5pMw4Gb@shell.armlinux.org.uk>
Date: Wed, 20 Jul 2022 12:35:19 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Sean Anderson <sean.anderson@...o.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Alexandru Marginean <alexandru.marginean@....com>,
Paolo Abeni <pabeni@...hat.com>,
"David S . Miller" <davem@...emloft.net>,
linux-kernel@...r.kernel.org, Vladimir Oltean <olteanv@...il.com>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH v2 10/11] net: phy: aquantia: Add some additional phy
interfaces
On Tue, Jul 19, 2022 at 07:50:00PM -0400, Sean Anderson wrote:
> +/* The following registers all have similar layouts; first the registers... */
> +#define VEND1_GLOBAL_CFG_10M 0x0310
> +#define VEND1_GLOBAL_CFG_100M 0x031b
> +#define VEND1_GLOBAL_CFG_1G 0x031c
> +#define VEND1_GLOBAL_CFG_2_5G 0x031d
> +#define VEND1_GLOBAL_CFG_5G 0x031e
> +#define VEND1_GLOBAL_CFG_10G 0x031f
> +/* ...and now the fields */
> +#define VEND1_GLOBAL_CFG_RATE_ADAPT GENMASK(8, 7)
> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_NONE 0
> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_USX 1
> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_PAUSE 2
> +
Shouldn't these definitions be in patch 11? They don't appear to be used
in this patch.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists