linux-kernel - Re: [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f8867c6-1bdf-0614-aeed-d39e328fda82@suse.de>
Date:   Wed, 20 Jul 2022 13:39:29 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <kch@...dia.com>,
        linux-nvme@...ts.infradead.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS

On 7/20/22 13:37, Lukas Bulwahn wrote:
> Commit 71ebe3842ebe ("nvmet-auth: Diffie-Hellman key exchange support")
> intends to select 'Support for RFC 7919 FFDHE group parameters' for using
> FFDHE groups for NVMe In-Band Authentication.
> 
> It however selects CRYPTO_DH_GROUPS_RFC7919, instead of the intended
> CRYPTO_DH_RFC7919_GROUPS; notice the swapping of words here.
> 
> Correct the select to the intended config option.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>   drivers/nvme/target/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
> index f0c91f7686a3..79fc64035ee3 100644
> --- a/drivers/nvme/target/Kconfig
> +++ b/drivers/nvme/target/Kconfig
> @@ -93,7 +93,7 @@ config NVME_TARGET_AUTH
>   	select CRYPTO_SHA256
>   	select CRYPTO_SHA512
>   	select CRYPTO_DH
> -	select CRYPTO_DH_GROUPS_RFC7919
> +	select CRYPTO_DH_RFC7919_GROUPS
>   	help
>   	  This enables support for NVMe over Fabrics In-band Authentication
>   
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes