linux-kernel - Re: [PATCH] selftests: gpio: fix include path to kernel headers for out of tree builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=McwEsmDw2SGfbf8EKm-sHpQCVoPcNj8QMuuAf-P59utnQ@mail.gmail.com>
Date:   Wed, 20 Jul 2022 14:35:37 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Kent Gibson <warthog618@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] selftests: gpio: fix include path to kernel headers for
 out of tree builds

On Tue, Jul 19, 2022 at 1:06 PM Kent Gibson <warthog618@...il.com> wrote:
>
> When building selftests out of the kernel tree the gpio.h the include
> path is incorrect and the build falls back to the system includes
> which may be outdated.
>
> Add the KHDR_INCLUDES to the CFLAGS to include the gpio.h from the
> build tree.
>
> Fixes: 4f4d0af7b2d9 ("selftests: gpio: restore CFLAGS options")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Kent Gibson <warthog618@...il.com>
> ---
>
> The test bot suggested
> 4f4d0af7b2d9 ("selftests: gpio: restore CFLAGS options")
> as the commit to be fixed, but the previous fix which turned out to be
> incomplete seems more appropriate.
>
>  tools/testing/selftests/gpio/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
> index 71b306602368..616ed4019655 100644
> --- a/tools/testing/selftests/gpio/Makefile
> +++ b/tools/testing/selftests/gpio/Makefile
> @@ -3,6 +3,6 @@
>  TEST_PROGS := gpio-mockup.sh gpio-sim.sh
>  TEST_FILES := gpio-mockup-sysfs.sh
>  TEST_GEN_PROGS_EXTENDED := gpio-mockup-cdev gpio-chip-info gpio-line-name
> -CFLAGS += -O2 -g -Wall -I../../../../usr/include/
> +CFLAGS += -O2 -g -Wall -I../../../../usr/include/ $(KHDR_INCLUDES)
>
>  include ../lib.mk
> --
> 2.37.1
>

Queued for fixes, thanks!

Bart