linux-kernel - Re: [PATCH v4 3/5] lib/test: Introduce cpumask KUnit test suite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38c839001bbd10f58d12c64d78b5f310ee55f9aa.camel@svanheule.net>
Date:   Wed, 20 Jul 2022 14:47:28 +0200
From:   Sander Vanheule <sander@...nheule.net>
To:     Maíra Canal <mairacanal@...eup.net>,
        akpm@...ux-foundation.org
Cc:     andriy.shevchenko@...ux.intel.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, elver@...gle.com,
        gregkh@...uxfoundation.org, hpa@...or.com,
        linux-kernel@...r.kernel.org, mingo@...hat.com,
        peterz@...radead.org, tglx@...utronix.de, vschneid@...hat.com,
        x86@...nel.org, yury.norov@...il.com,
        Brendan Higgins <brendanhiggins@...gle.com>,
        David Gow <davidgow@...gle.com>
Subject: Re: [PATCH v4 3/5] lib/test: Introduce cpumask KUnit test suite

Hi,

On Tue, 2022-07-19 at 18:31 -0300, Maíra Canal wrote:
> > Add a basic suite of tests for cpumask, providing some tests for empty
> > and completely filled cpumasks.
> > 
> > Signed-off-by: Sander Vanheule <sander@...nheule.net>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> The tests test_cpumask_weight and test_cpumask_last are failing on all
> architectures, as can be seen on [1]. Also this test doesn't follow the
> standard style for KUnit tests [2].
> 
> [1]
> https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20220718/testrun/10865066/suite/kunit/tests/
> [2] https://docs.kernel.org/dev-tools/kunit/style.html

Thanks for the feedback, I wasn't aware of the style guidelines. See my reply to
David's message for the issues with the cpu_possible_mask tests.

Andrew, would you like me to resubmit the entire series, or can I just send a
new version of this patch?

Best,
Sander