linux-kernel - Re: [PATCH] fs: drop_caches: skip dropping pagecache which is always dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtgY7CEWvcqywK1/@casper.infradead.org>
Date:   Wed, 20 Jul 2022 16:02:04 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     CGEL <cgel.zte@...il.com>
Cc:     viro@...iv.linux.org.uk, hughd@...gle.com,
        akpm@...ux-foundation.org, hch@...radead.org,
        hsiangkao@...ux.alibaba.com, yang.yang29@....com.cn,
        axboe@...nel.dk, yangerkun@...wei.com, johannes.thumshirn@....com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Ran Xiaokai <ran.xiaokai@....com.cn>
Subject: Re: [PATCH] fs: drop_caches: skip dropping pagecache which is always
 dirty

On Wed, Jul 20, 2022 at 06:02:32AM +0000, CGEL wrote:
> On Wed, Jul 20, 2022 at 04:02:40AM +0100, Matthew Wilcox wrote:
> > On Wed, Jul 20, 2022 at 02:21:19AM +0000, cgel.zte@...il.com wrote:
> > > From: Yang Yang <yang.yang29@....com.cn>
> > > 
> > > Pagecache of some kind of fs has PG_dirty bit set once it was
> > > allocated, so it can't be dropped. These fs include ramfs and
> > > tmpfs. This can make drop_pagecache_sb() more efficient.
> > 
> > Why do we want to make drop_pagecache_sb() more efficient?
> 
> Some users may use drop_caches besides testing or debugging.

This is a terrible reason.

> For example, some systems will create a lot of pagecache when boot up
> while reading bzImage, ramdisk, docker images etc. Most of this pagecache
> is useless after boot up. It may has a longterm negative effects for the
> workload when trigger page reclaim. It is especially harmful when trigger
> direct_reclaim or we need allocate pages in atomic context. So users may
> chose to drop_caches after boot up.

If that's actually a problem, work on fixing that.