linux-kernel - Re: [PATCH v2 2/6] PCI: brcmstb: Split brcm_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220721161013.GA1725073@bhelgaas>
Date:   Thu, 21 Jul 2022 11:10:13 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Jim Quinlan <james.quinlan@...adcom.com>
Cc:     Jim Quinlan <jim2101024@...il.com>,
        "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" 
        <linux-pci@...r.kernel.org>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Cyril Brulebois <kibi@...ian.org>,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@...ts.infradead.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/6] PCI: brcmstb: Split brcm_pcie_setup() into two
 funcs

On Thu, Jul 21, 2022 at 10:56:53AM -0400, Jim Quinlan wrote:
> On Wed, Jul 20, 2022 at 4:37 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
> > On Mon, Jul 18, 2022 at 05:40:33PM -0500, Bjorn Helgaas wrote:
> > > On Mon, Jul 18, 2022 at 01:14:25PM -0500, Bjorn Helgaas wrote:
> > > > ...
> > >
> > > > So I think brcm_pcie_setup() does initialization that doesn't depend
> > > > on the link or any downstream devices, and brcm_pcie_start_link() does
> > > > things that depend on the link being up.  Right?
> > > >
> > > > If so, "start_link" might be a slight misnomer since AFAICT
> > > > brcm_pcie_start_link() doesn't do anything to initiate link-up except
> > > > maybe deasserting fundamental reset.  Some drivers start the LTSSM or
> > > > explicitly enable link training, but brcm_pcie_start_link() doesn't
> > > > seem to do anything like that.
> > > >
> > > > brcm_pcie_start_link() still does brcm_pcie_set_outbound_win().  Does
> > > > that really depend on the link being up?  If that only affects the
> > > > Root Port, maybe it could be done before link-up?
> > >
> > > What about the /* PCIe->SCB endian mode for BAR */ thing?  Does that
> > > depend on the link being up?
> > >
> > > And the "Refclk from RC should be gated with CLKREQ#" part?  Does that
> > > depend on the link being up?
> > >
> > > It seems obvious that brcm_pcie_set_ssc() and reading the negotiated
> > > link speed and width depend on the link being up.
> >
> > Can we close on this?  Splitting into
>
> Absolutely.
> 
> >   (a) stuff that can be initialized before the link is available and
> >   (b) stuff that depends on the link
> >
> > makes good sense, but then (b) should only contain stuff that actually
> > depends on the link.
> >
> > The "PCIe->SCB endian mode for BAR" *sounds* like something related to
> > the primary side of the RP, not the link.
> >
> > Not sure about "Refclk from RC".  RC would certainly be primary side,
> > but ASPM has to do with secondary (link) side.
> 
> I get the feedback, submission coming soon -- I was waiting for the
> email thread to conclude.

I don't expect a new posting of the patches in response to every
question, but hopefully this is a conversation that goes both ways,
and there's no need to slow down the conversation.  It's more than
acceptable to simply ask and answer questions and post updated patches
later.  We're running out of runway and I want to make sure we get
this thing done this cycle.

Bjorn