linux-kernel - Re: [PATCH v3 2/2] printk: console: Support console-specific loglevels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ytl/B6pLOCRYVc7p@chrisdown.name>
Date:   Thu, 21 Jul 2022 17:29:59 +0100
From:   Chris Down <chris@...isdown.name>
To:     kernel test robot <lkp@...el.com>
Cc:     linux-kernel@...r.kernel.org, kbuild-all@...ts.01.org,
        Petr Mladek <pmladek@...e.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        John Ogness <john.ogness@...utronix.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>, kernel-team@...com
Subject: Re: [PATCH v3 2/2] printk: console: Support console-specific
 loglevels

kernel test robot writes:
>sparse warnings: (new ones prefixed by >>)
>>> kernel/printk/sysctl.c:31:47: sparse: sparse: incorrect type in argument 3 (different address spaces) @@     expected void * @@     got void [noderef] __user *buffer @@
>   kernel/printk/sysctl.c:31:47: sparse:     expected void *
>   kernel/printk/sysctl.c:31:47: sparse:     got void [noderef] __user *buffer

Ah, since commit 32927393dc1c ("sysctl: pass kernel pointers to 
->proc_handler") we copy to kernelspace before passing to the callback, so it's 
not a userspace pointer. That's certainly an improvement.

Will fix for v4.