linux-kernel - Re: [PATCH RESEND] scripts/gdb: Fix gdb 'lx-symbols' command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ytl/xkb9OC43dgJd@bombadil.infradead.org>
Date:   Thu, 21 Jul 2022 09:33:10 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Doug Anderson <dianders@...omium.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Khalid Masum <khalid.masum.92@...il.com>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        LKML <linux-kernel@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Pavel Skripkin <paskripkin@...il.com>,
        Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kbingham@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Aaron Tomlin <atomlin@...hat.com>,
        kgdb-bugreport@...ts.sourceforge.net
Subject: Re: [PATCH RESEND] scripts/gdb: Fix gdb 'lx-symbols' command

On Thu, Jul 21, 2022 at 09:24:31AM -0700, Doug Anderson wrote:
> Hi,
> 
> On Thu, Jul 21, 2022 at 2:31 AM Khalid Masum <khalid.masum.92@...il.com> wrote:
> >
> > Currently the command 'lx-symbols' in gdb exits with the error`Function
> > "do_init_module" not defined in "kernel/module.c"`. This occurs because
> > the file kernel/module.c was moved to kernel/module/main.c.
> >
> > Fix this breakage by changing the path to "kernel/module/main.c" in
> > LoadModuleBreakpoint.
> >
> > Signed-off-by: Khalid Masum <khalid.masum.92@...il.com>
> > ---
> >  scripts/gdb/linux/symbols.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
> > index 46f7542db08c..dc07b6d12e30 100644
> > --- a/scripts/gdb/linux/symbols.py
> > +++ b/scripts/gdb/linux/symbols.py
> > @@ -180,7 +180,7 @@ lx-symbols command."""
> >                  self.breakpoint.delete()
> >                  self.breakpoint = None
> >              self.breakpoint = LoadModuleBreakpoint(
> > -                "kernel/module.c:do_init_module", self)
> > +                "kernel/module/main.c:do_init_module", self)
> 
> Fixes: cfc1d277891e ("module: Move all into module/")
> Reviewed-by: Douglas Anderson <dianders@...omium.org>

Acked-by: Luis Chamberlain <mcgrof@...nel.org>

This should go to Linus prior to the next rc.  Linus, I think this is
with picking up now as I smell a final release soon.

FWIW a git grep of "kernel/module\.c" reveals no other code users of
this path.

  Luis