linux-kernel - Re: [RESEND PATCH 3/9] arm64: dts: bcmbca: update BCM4908 board dts files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62efc265-aeea-4394-2844-d54fdb0e05b7@broadcom.com>
Date:   Thu, 21 Jul 2022 10:54:19 -0700
From:   William Zhang <william.zhang@...adcom.com>
To:     Rafał Miłecki <rafal@...ecki.pl>
Cc:     Linux ARM List <linux-arm-kernel@...ts.infradead.org>,
        joel.peshkin@...adcom.com, dan.beygelman@...adcom.com,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH 3/9] arm64: dts: bcmbca: update BCM4908 board dts
 files



On 07/20/2022 11:15 PM, Rafał Miłecki wrote:
> On 2022-07-21 02:07, William Zhang wrote:
>> Append "brcm,bcmbca" to compatible strings based on the new bcmbca
>> binding rule for BCM4908 family based boards. This will break drivers
>> that use the old compatible string for binding. Fortunately there is no
>> such usage in linux and u-boot.
> 
> Why should an extra "compatible" value break anything? I don't think it
> will happen unless some driver does some really crazy stuff (like
> checking full list of "compatible" values).
> 
Yes anything along those lines will break. But there is no such 
craziness in linux and u-boot(wouldn't be accepted in first place).  But 
Krzysztof suggested to add that to the commit message.  I would prefer 
not to add that either.

> 
>> Signed-off-by: William Zhang <william.zhang@...adcom.com>
> 
> Other than confusing commit message:
> 
> Acked-by: Rafał Miłecki <rafal@...ecki.pl>
> 
> 
>> ---
>>
>>  arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts | 2 +-
>>  .../dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts     | 2 +-
>>  arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts | 2 +-
>>  .../arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts | 2 +-
>>  4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git
>> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> index 2dd028438c22..d8b60575eb4f 100644
>> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> @@ -7,7 +7,7 @@
>>  #include "bcm4906.dtsi"
>>
>>  / {
>> -    compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908";
>> +    compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908", 
>> "brcm,bcmbca";
>>      model = "Netgear R8000P";
>>
>>      memory@0 {
>> diff --git
>> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> index 064f7f549665..296393d4aaab 100644
>> --- 
>> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> +++ 
>> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> @@ -7,7 +7,7 @@
>>  #include "bcm4906.dtsi"
>>
>>  / {
>> -    compatible = "tplink,archer-c2300-v1", "brcm,bcm4906", 
>> "brcm,bcm4908";
>> +    compatible = "tplink,archer-c2300-v1", "brcm,bcm4906",
>> "brcm,bcm4908", "brcm,bcmbca";
>>      model = "TP-Link Archer C2300 V1";
>>
>>      memory@0 {
>> diff --git
>> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> index 04f8524b5335..787c7ddf9102 100644
>> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> @@ -6,7 +6,7 @@
>>  #include "bcm4908.dtsi"
>>
>>  / {
>> -    compatible = "asus,gt-ac5300", "brcm,bcm4908";
>> +    compatible = "asus,gt-ac5300", "brcm,bcm4908", "brcm,bcmbca";
>>      model = "Asus GT-AC5300";
>>
>>      memory@0 {
>> diff --git
>> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> index 3c2cf2d238b6..23b96c663239 100644
>> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> @@ -3,7 +3,7 @@
>>  #include "bcm4908.dtsi"
>>
>>  / {
>> -    compatible = "netgear,raxe500", "brcm,bcm4908";
>> +    compatible = "netgear,raxe500", "brcm,bcm4908", "brcm,bcmbca";
>>      model = "Netgear RAXE500";
>>
>>      memory@0 {

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)