linux-kernel - Re: [PATCH v5 11/12] thermal/of: Use thermal trips stored in the thermal zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e9f6d35-08ff-4949-67b0-a2feaab79814@linexp.org>
Date:   Thu, 21 Jul 2022 23:29:23 +0200
From:   Daniel Lezcano <daniel.lezcano@...exp.org>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        "Zhang, Rui" <rui.zhang@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kevin Hilman <khilman@...libre.com>,
        Alexandre Bailon <abailon@...libre.com>,
        Lukasz Luba <lukasz.luba@....com>,
        Amit Kucheria <amitk@...nel.org>
Subject: Re: [PATCH v5 11/12] thermal/of: Use thermal trips stored in the
 thermal zone

On 19/07/2022 20:26, Rafael J. Wysocki wrote:
> On Sun, Jul 10, 2022 at 2:35 PM Daniel Lezcano
> <daniel.lezcano@...exp.org> wrote:
>> Now that we have the thermal trip stored in the thermal zone in a
>> generic way, we can rely on them and remove one indirection we found
>> in the thermal_of code and do one more step forward the removal of the
>> duplicated structures.
>>
>> Cc: Alexandre Bailon <abailon@...libre.com>
>> Cc: Kevin Hilman <khilman@...libre.com>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...exp.org>
>> ---
>>   drivers/thermal/thermal_of.c | 53 +++++++++++-------------------------
>>   1 file changed, 16 insertions(+), 37 deletions(-)
>>
>> diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
>> index e187461dd396..601552c55d0b 100644
>> --- a/drivers/thermal/thermal_of.c
>> +++ b/drivers/thermal/thermal_of.c
>> @@ -118,12 +118,7 @@ static int of_thermal_set_trips(struct thermal_zone_device *tz,
>>    */
>>   int of_thermal_get_ntrips(struct thermal_zone_device *tz)
>>   {
>> -       struct __thermal_zone *data = tz->devdata;
>> -
>> -       if (!data || IS_ERR(data))
>> -               return -ENODEV;
>> -
>> -       return data->ntrips;
>> +       return tz->ntrips;
> Hasn't this been renamed to num_trips?

Right, it is changed in patch 12/12