linux-kernel - Re: [PATCH 2/2] ARM: dts: qcom: ipq8064: pad addresses to 8 digit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a975956c-edbb-861c-e352-8a168e7cb536@linaro.org>
Date:   Fri, 22 Jul 2022 00:58:40 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Christian Marangi <ansuelsmth@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: ipq8064: pad addresses to 8 digit

On 18/07/2022 18:38, Christian Marangi wrote:
> Pad reg addresses to 8 digit to make sorting easier.

Please put this patch before the patch 1/2. It makes reviewing easier.
Otherwise:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

> 
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>   arch/arm/boot/dts/qcom-ipq8064.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index cf41d330c920..9405d6167b20 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -348,7 +348,7 @@ vsdcc_fixed: vsdcc-regulator {
>   
>   		rpm: rpm@...000 {
>   			compatible = "qcom,rpm-ipq8064";
> -			reg = <0x108000 0x1000>;
> +			reg = <0x00108000 0x1000>;
>   			qcom,ipc = <&l2cc 0x8 2>;
>   
>   			interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
> @@ -389,7 +389,7 @@ tsens_calib_backup: calib_backup@410 {
>   
>   		qcom_pinmux: pinmux@...000 {
>   			compatible = "qcom,ipq8064-pinctrl";
> -			reg = <0x800000 0x4000>;
> +			reg = <0x00800000 0x4000>;
>   
>   			gpio-controller;
>   			gpio-ranges = <&qcom_pinmux 0 0 69>;
> @@ -571,7 +571,7 @@ IRQ_TYPE_EDGE_RISING)>,
>   
>   		l2cc: clock-controller@...1000 {
>   			compatible = "qcom,kpss-gcc", "syscon";
> -			reg = <0x2011000 0x1000>;
> +			reg = <0x02011000 0x1000>;
>   			clocks = <&gcc PLL8_VOTE>, <&pxo_board>;
>   			clock-names = "pll8_vote", "pxo";
>   			clock-output-names = "acpu_l2_aux";


-- 
With best wishes
Dmitry