linux-kernel - Re: [PATCH 3/5] ASoC: amd: acp: Initialize list to store acp_stream during pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtnR05hxiWNKOGoC@sirena.org.uk>
Date:   Thu, 21 Jul 2022 23:23:15 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Venkata Prasad Potturu <venkataprasad.potturu@....com>
Cc:     alsa-devel@...a-project.org, vsujithkumar.reddy@....com,
        Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
        Sunil-kumar.Dommati@....com, ssabakar@....com,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/5] ASoC: amd: acp: Initialize list to store acp_stream
 during pcm_open

On Thu, Jul 21, 2022 at 11:50:35AM +0530, Venkata Prasad Potturu wrote:
> From: Ajit Kumar Pandey <AjitKumar.Pandey@....com>
> 
> We are currently allocating acp_stream during pcm_open and saving
> it in static array corresponds to array index calculated based on
> cpu dai->driver id. This approach will fail if we have single dai
> linked to multiple pcm device as we will have same dai->driver id
> or array index for multiple pcm open. Initialize new linked list
> stream_list to store opened pcm stream info dynamically.

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/amd/acp/acp-platform.c: In function ‘i2s_irq_handler’:
/build/stage/linux/sound/soc/amd/acp/acp-platform.c:108:31: error: ‘struct acp_dev_data’ has no member named ‘stream’
  108 |                 stream = adata->stream[i];
      |                               ^~
make[5]: *** [/build/stage/linux/scripts/Makefile.build:249: sound/soc/amd/acp/acp-platform.o] Error 1

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)