linux-kernel - Re: [PATCH] staging: r8188eu: Inserted empty line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b12cf068-9494-b38c-a1a9-8ec3d68f906e@gmail.com>
Date:   Thu, 21 Jul 2022 06:59:50 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Abhijeet Srivastava <abhijeet.srivastava2308@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Pavel Skripkin <paskripkin@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        Rebecca Mckeever <remckee0@...il.com>,
        Martin Kaiser <martin@...ser.cx>,
        Vihas Makwana <makvihas@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Inserted empty line after declarations

On 7/21/22 05:50, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script. Resending this patch after
> correcting my Username
> 
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@...il.com>
> ---
>   drivers/staging/r8188eu/core/rtw_cmd.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
> index 5b6a891b5d67..6fbf6e4234cf 100644
> --- a/drivers/staging/r8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
> @@ -25,6 +25,7 @@ void rtw_free_evt_priv(struct	evt_priv *pevtpriv)
>   
>   	while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
>   		void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
> +
>   		if (c2h && c2h != (void *)pevtpriv)
>   			kfree(c2h);
>   	}
> @@ -323,6 +324,7 @@ u8 rtw_sitesurvey_cmd(struct adapter  *padapter, struct ndis_802_11_ssid *ssid,
>   	/* prepare ssid list */
>   	if (ssid) {
>   		int i;
> +
>   		for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) {
>   			if (ssid[i].SsidLength) {
>   				memcpy(&psurveyPara->ssid[i], &ssid[i], sizeof(struct ndis_802_11_ssid));
> @@ -334,6 +336,7 @@ u8 rtw_sitesurvey_cmd(struct adapter  *padapter, struct ndis_802_11_ssid *ssid,
>   	/* prepare channel list */
>   	if (ch) {
>   		int i;
> +
>   		for (i = 0; i < ch_num && i < RTW_CHANNEL_SCAN_AMOUNT; i++) {
>   			if (ch[i].hw_value && !(ch[i].flags & RTW_IEEE80211_CHAN_DISABLED)) {
>   				memcpy(&psurveyPara->ch[i], &ch[i], sizeof(struct rtw_ieee80211_channel));

Hi,

I am sorry to tell you that this patch is unlikely to be accepted.

Reason is that you need a [PATCH v2] subject and that the change 
information needs to be below the (signed off line and the "---")

Find an example here:
https://lore.kernel.org/linux-staging/20220718021241.GA8270@cloud-MacBookPro/T/#m7a25ce1dd320c742bfb0ca0236ca06476d8dd8eb

And read about the canonical patch style.

Consider that the next version you send is not v2. Because this was v2. 
The next version you can send is already v3.

Thanks for your patch. You can do it.

Bye Philipp